Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More H5FDs3comms.c/h cleanup #5231

Merged
merged 3 commits into from
Jan 14, 2025
Merged

More H5FDs3comms.c/h cleanup #5231

merged 3 commits into from
Jan 14, 2025

Conversation

derobins
Copy link
Member

@derobins derobins commented Jan 14, 2025 •
edited
Loading

  • Make more error lines like the rest of the library (i.e., check for negative herr_t instead of FAIL)
  • Rename functions that create AWS strings to include _make_aws_ in the name
  • Separate out the test-only load AWS credentials function
  • Other minor cleanup

More H5FDs3comms.c/h cleanup
fac8e96 
* Make more error lines like the rest of the library (i.e., check for
  negative herr_t instead of FAIL)
* Rename functions that create AWS strings to include _make_aws_
  in the name
* Separate out the test-only load AWS credentials function
* Other minor cleanup
@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Jan 14, 2025
derobins
derobins commented Jan 14, 2025
View reviewed changes
src/H5FDs3comms.h
@@ -452,52 +452,37 @@ typedef struct {
extern "C" {
#endif

/****************************
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks messy, but if you look at the raw files you'll see it's just some reorg.

@lrknox lrknox merged commit 01d5a97 into HDFGroup:develop Jan 14, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmribler bmribler bmribler approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@mattjala mattjala mattjala approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derobins @bmribler @byrnHDF @mattjala @lrknox